Conversation
|
Preview: Removed (PR closed). |
tortmayr
force-pushed
the
restyle-2
branch
4 times, most recently
from
6008cf1 to
e3a4f42
Compare
tortmayr
force-pushed
the
restyle-2
branch
3 times, most recently
from
69bee60 to
0177602
Compare
tortmayr
changed the title
tortmayr
force-pushed
the
restyle-2
branch
2 times, most recently
from
c78f825 to
91bc613
Compare
## Switch to esbuild for bundling Part-of: eclipse-glsp/glsp#1693 ## Redesign standalone example app - Central diagram widget - Proper title bar - Additional toggleable section for keyboard bindings Add/introduce following features - Context menu support - Server-side provided context menus - Navigation/Marker menu entries - Edit task menu entries - Title bar with - Diagram menu similar to Theia integration - Including layout commands - Dirty state marker - Undo/Redo buttons - Theming support - 5 seletable themes - light/dark mode variants - Theme switcher in title bar - Extended urlParameter configuration - grid,readonly,mcp,theme,mode Fixes eclipse-glsp/glsp#31 ## Additional fixes - Fixes an issue with the GLSP Projection view which did not calculate scrollbars correctly for the diagrams that are off-center (don't start at 0,0) - Fixes an issue with the GLSPWebSocketConnectionHandler which did not properly try to reconnect if it was launched before the server was available - Add comment section to claude.md
tortmayr
requested review from
martin-fleck-at
and removed request for
martin-fleck-at
|
@martin-fleck-at Could you please review this change. Sorry, its quite large 😉 @planger @haydar-metin If you have time please test the reworked standalone example. |
planger
left a comment
planger
left a comment
There was a problem hiding this comment.
Wow this is just wonderful! Very very beautiful, modern, but not overdone.
Excellent work, thank you very much!
That is a lie! 
The shadow at the bottom is cut off. Just an opinion without a solution: the scrollbars are sometimes hard to see. I'm not sure if it is fixable: You can not move the scrollbar if the cursor is outside of the frame. 
Not sure if we should fix that :D Amazing work! Looks soooo much better now. |
| <span class="shortcuts-chevron" id="shortcutsChevron">▸</span> | ||
| Keyboard Shortcuts | ||
| </div> | ||
| <div class="shortcuts-panel" id="shortcutsPanel"> |
There was a problem hiding this comment.
We should implement a registry for all possible shortcuts as a follow up (I'm not sure if we have already something similar with the accessibility implementation). This would also allow us to identify if two shortcuts are bound in the same context.
There was a problem hiding this comment.
Yeah, we should do this as a follow-up issue
|
Thanks for the review @haydar-metin. I fixed the first three mentioned issue. The other two are not easily fixable, and i think the behaviors is okay for an example app. |
3 participants
What it does
GLSP-31: Update workflow example (standalone)
Migrate bundling to esbuild
Part-of: eclipse-glsp/glsp#1693
Rework workflow-standalone example
Add/introduce following features
Fixes eclipse-glsp/glsp#31
Additional fixes
Fixes an issue with the GLSP Projection view which did not calculate
scrollbars correctly for the diagrams that are off-center (don't start
at 0,0)
Fixes an issue with the GLSPWebSocketConnectionHandler which did not
properly try to reconnect if it was launched before the server was
available
Add comment section to claude.md
How to test
Follow-ups
Changelog
-Workflow-example redesign is not part of the changelog, but the fix for the projection view should be part of it